Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isArrayOfTrytes method in ValidatorUtil class #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add isArrayOfTrytes method in ValidatorUtil class #70

wants to merge 1 commit into from

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Sep 26, 2018 •
edited
Loading

@peter279k peter279k self-assigned this Sep 26, 2018
@peter279k
Copy link
Contributor Author

@Techworker, please review this PR. Thanks.

Techworker
Techworker reviewed Oct 1, 2018
View reviewed changes
Copy link
Member

@Techworker Techworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you added the 2673 as a required length. The method is called isArrayOfTrytes and a trytestring does not necessarily need to be 2673 trytes long.

@peter279k
Copy link
Contributor Author

Hi @Techworker, thank you for your reply.
I refer this line and I found that this should check the trytes is 2673.

Is this unnecessary? Thanks.

@Techworker
Copy link
Member

I think its unnecessary

@peter279k
Copy link
Contributor Author

Hi @Techworker, thank you for your reply. Do you mean I remove this 2673, and using the default value?

It makes sense I think. I will try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techworker Techworker Techworker left review comments

Assignees

@peter279k peter279k

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @Techworker